Allow custom delimiter for background images #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ApoorvSaxena
approved these changes
May 23, 2020
|
@alex-bowers would have loved to see accompanying test cases with PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully, this is a solution for #238
There are some image URLs that include commas and this is perfectly valid. Which means a single URL like the example below is currently being broken up into multiple images, when we use
data-background-image.The simplest way to fix this issue is to allow the user to choose their own delimiter. Each use case may be different.
I've needed to create this so that I could use a delimiter of a comma and a space,
,. I've added a clearer example of a dash to the readme.