Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a mutationObserver to reload when some valid attributes changes #192

Merged
merged 14 commits into from Sep 10, 2020

Conversation

iam-frankqiu
Copy link
Contributor

Added a MutationObserver to some valid attributes like data-src, when data-src changed, reload

@ApoorvSaxena
Copy link
Owner

@frankqiu0219 Please add this information in README and Demo file with an example as well. This will be a great addition as functionality.

@iam-frankqiu
Copy link
Contributor Author

@frankqiu0219 Please add this information in README and Demo file with an example as well. This will be a great addition as functionality.
Thank you. I will do it quickly.

@ApoorvSaxena
Copy link
Owner

@iam-frankqiu please fix the conflicting issues, also, a configuration should allow to disable the use of Mutation Observer, and it shouldn't be enabled by default, considering the performance implications

@ApoorvSaxena
Copy link
Owner

@iam-frankqiu any updates on this?

@iam-frankqiu
Copy link
Contributor Author

@iam-frankqiu any updates on this?

yeah, sorry for the late reply, I was pretty busy, I will update this repository soon.

@ApoorvSaxena
Copy link
Owner

@iam-frankqiu please add coverage folder in .gitignore

@iam-frankqiu
Copy link
Contributor Author

@iam-frankqiu please add coverage folder in .gitignore

well. It's done.

@ApoorvSaxena ApoorvSaxena merged commit 146b6ba into ApoorvSaxena:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants