Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes lazy loading a Picture element more simple (IMHO) #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jab2870
Copy link

@Jab2870 Jab2870 commented Nov 10, 2018

This links to the issue #144.

@kevinmu17
Copy link

Why isn't this merged with the master? 2018....

@ApoorvSaxena
Copy link
Owner

@kevinmu17 merge conflicts are yet to be resolved

@kevinmu17
Copy link

kevinmu17 commented Jul 21, 2020

@ApoorvSaxena, from what i can see there is not a merge conflict perse. the src file has to be updated and then the dist shall update to right? The changes are made in a dist file which is wrong right?

const img = document.createElement('img')

it should be change here, but than again, the dist is a production folder and should be reuploaded when creating a build in order to get rid of the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants